Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port dspace-7_x] Fixed MathJax code being displayed twice by dsMarkdown pipe #2392

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[Port dspace-7_x] Fixed MathJax code being displayed twice by dsMarkdown pipe #2392

merged 1 commit into from
Aug 3, 2023

Conversation

alexandrevryghem
Copy link
Member

@alexandrevryghem alexandrevryghem commented Jul 21, 2023 •
edited
Loading

@alexandrevryghem
Fix mathjax code being displayed twice
15656b0 
This was due to sanitizeHtml rendering the mjx-assistive-mml tag as text. This tag is used by screen readers and therefor we should allow it to be rendered
@alexandrevryghem alexandrevryghem self-assigned this Jul 21, 2023
@alexandrevryghem alexandrevryghem added this to the 7.6.1 milestone Jul 21, 2023
@tdonohue tdonohue added the port to main This PR needs to be ported to `main` branch for the next major release label Jul 24, 2023
@alexandrevryghem alexandrevryghem mentioned this pull request Jul 25, 2023
Merged
8 tasks
@alexandrevryghem alexandrevryghem removed the port to main This PR needs to be ported to `main` branch for the next major release label Jul 25, 2023
@tdonohue tdonohue self-requested a review July 27, 2023 14:30
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jul 27, 2023
@eulereadgbe
Copy link
Contributor

I tested this pull request and resolved my issue of displaying the MathJax code twice. So thumbs up for this pull request.

@alexandrevryghem alexandrevryghem changed the title Fixed MathJax code being displayed twice by dsMarkdown pipe [Port dspace-7_x] Fixed MathJax code being displayed twice by dsMarkdown pipe Aug 2, 2023
tdonohue
tdonohue approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! Tested this locally and verified it fixes the bug. Code looks good too.

(NOTE: Ported to 8.0 in #2397)

@tdonohue tdonohue merged commit 99e349b into DSpace:dspace-7_x Aug 3, 2023
@alexandrevryghem alexandrevryghem deleted the fix-mathjax-displaying-twiced-in-ui_contribute-maintenance-7.6 branch August 3, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@alexandrevryghem alexandrevryghem

Labels
1 APPROVAL pull request only requires a single approval to merge bug medium priority usability ux User Experience related works
Projects
DSpace 8.x and 7.6.x Maintenance
Archived in project
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandrevryghem @eulereadgbe @tdonohue